#error Missing Bus Glue For Ohci-hcd
sorted by: [ date ] [ thread ] [ subject ] [ author ] Hi, I wanted to see if I could add support for the skytone alpha 400 netbook, so first I wanted to build the plain qi kernel. I got me a buildroot to build the mipsel toolchain, but when I try building the qi-kernel with $ make ARCH=mips CROSS_COMPILE=../buildroot-2009.11/output/staging/usr/bin/mipsel-linux- uImage I get drivers/usb/host/ohci-hcd.c:1092:2: error: #error "missing bus glue for ohci-hcd" make[3]: *** [drivers/usb/host/ohci-hcd.o] Error 1 Am I missing something? Thanks. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 197 bytes Desc: not available URL: Previous message: Question Next message: compiling with buildroot - missing bus glue for ohci-hcd Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] More information about the discussion mailing list Main page Current events Mailing lists Planet Projects server interactive About Qi Community portal Recent changes Contact Qi Help All content is dual licensed under CC-BY-SA and GFDL; additional terms may apply. See Copyright for details. Privacy policy About Qi Disclaimers
2 May 2013 17:16:21 +0200The OHCI driver currently gives a build error if the base driver isenabled but none of its bus glues are turned on:drivers/usb/host/ohci-hcd.c:1209:2: error: #error "missing bus glue for ohci-hcd" #error "missing bus glue for ohci-hcd"A better solution for this is to change the Kconfig statements toprevent getting into this situation. This adds a new USB_UHCI_COREsymbol in Kconfig, which is selected by each of the bus glues.This way, the driver never gets built if all of them are disabled.Cc: Alan Stern Cc: Greg http://lists.en.qi-hardware.com/pipermail/discussion/2010-February/001922.html Kroah-Hartman Signed-off-by: Arnd Bergmann --- drivers/usb/host/Kconfig | 29 +++++++++++++++++++++++++++++ drivers/usb/host/Makefile | 2 +- drivers/usb/host/ohci-hcd.c | 19 ------------------- 3 files changed, 30 insertions(+), 20 deletions(-)diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfigindex 656af4d..46d1b9e 100644--- a/drivers/usb/host/Kconfig+++ b/drivers/usb/host/Kconfig@@ -368,9 +368,30 @@ config USB_OHCI_HCD if USB_OHCI_HCD +config USB_OHCI_CORE+ tristate+ depends on USB_OHCI_HCD+ default y if PCI+ default y if ARCH_SA1100 && SA1111+ default y if ARCH_S3C24XX+ default y if https://lkml.org/lkml/2013/5/2/301 ARCH_S3C64XX+ default y if PXA27x+ default y if PXA3xx+ default y if ARCH_EP93XX+ default y if ARCH_AT91+ default y if ARCH_LPC32XX+ default y if ARCH_DAVINCI_DA8XX+ default y if PLAT_SPEAR+ default y if PPC_PS3+ default y if MFD_SM501+ default y if MFD_TC6393XB+ default y if MACH_JZ4740+ default y if TILE_USB+ config USB_OHCI_HCD_OMAP1 bool "OHCI support for OMAP1/2 chips" depends on ARCH_OMAP1+ select USB_OHCI_CORE default y ---help--- Enables support for the OHCI controller on OMAP1/2 chips.@@ -378,6 +399,7 @@ config USB_OHCI_HCD_OMAP1 config USB_OHCI_HCD_OMAP3 bool "OHCI support for OMAP3 and later chips" depends on (ARCH_OMAP3 || ARCH_OMAP4)+ select USB_OHCI_CORE default y ---help--- Enables support for the on-chip OHCI controller on@@ -398,6 +420,7 @@ config USB_OHCI_ATH79 config USB_OHCI_HCD_PPC_OF_BE bool "OHCI support for OF platform bus (big endian)" depends on PPC_OF+ select USB_OHCI_CORE select USB_OHCI_BIG_ENDIAN_DESC select USB_OHCI_BIG_ENDIAN_MMIO ---help---@@ -407,6 +430,7 @@ config USB_OHCI_HCD_PPC_OF_BE config USB_OHCI_HCD_PPC_OF_LE bool "OHCI support for OF platform bus (little endian)" depends on PPC_OF+ select USB_OHCI_CORE select USB_OHCI_LITTLE_ENDIAN ---help--- Enables support for little-endian USB controllers present on the@@ -421,6 +445,7 @@ config USB_OHCI_HCD_PCI bool "OHCI support for PCI-bus USB controllers"
22/22] radio-si4713: depend on SND_SOC" In reply to: Arnd Bergmann: "Re: [PATCH, RFC 22/22] radio-si4713: depend on SND_SOC" Next in thread: Arnd Bergmann: "[PATCH, RFC 08/22] OMAPDSS: DPI needs DSI" Messages sorted http://lkml.iu.edu/hypermail/linux/kernel/1305.0/00769.html by: [ date ] [ thread ] [ subject ] [ author ] https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.6/800-usb-ohci-multiple-platform-driver-fix.patch?rev=35194 The OHCI driver currently gives a build error if the base driver is enabled but none of its bus glues are turned on: drivers/usb/host/ohci-hcd.c:1209:2: error: #error "missing bus glue for ohci-hcd" #error "missing bus glue for ohci-hcd" A better solution for this is to change the Kconfig statements to prevent getting into this situation. #error missing This adds a new USB_UHCI_CORE symbol in Kconfig, which is selected by each of the bus glues. This way, the driver never gets built if all of them are disabled. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Arnd Bergmann --- drivers/usb/host/Kconfig | 29 +++++++++++++++++++++++++++++ drivers/usb/host/Makefile | 2 +- drivers/usb/host/ohci-hcd.c | 19 ------------------- 3 files changed, 30 insertions(+), 20 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index #error missing bus 656af4d..46d1b9e 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -368,9 +368,30 @@ config USB_OHCI_HCD if USB_OHCI_HCD +config USB_OHCI_CORE + tristate + depends on USB_OHCI_HCD + default y if PCI + default y if ARCH_SA1100 && SA1111 + default y if ARCH_S3C24XX + default y if ARCH_S3C64XX + default y if PXA27x + default y if PXA3xx + default y if ARCH_EP93XX + default y if ARCH_AT91 + default y if ARCH_LPC32XX + default y if ARCH_DAVINCI_DA8XX + default y if PLAT_SPEAR + default y if PPC_PS3 + default y if MFD_SM501 + default y if MFD_TC6393XB + default y if MACH_JZ4740 + default y if TILE_USB + config USB_OHCI_HCD_OMAP1 bool "OHCI support for OMAP1/2 chips" depends on ARCH_OMAP1 + select USB_OHCI_CORE default y ---help--- Enables support for the OHCI controller on OMAP1/2 chips. @@ -378,6 +399,7 @@ config USB_OHCI_HCD_OMAP1 config USB_OHCI_HCD_OMAP3 bool "OHCI support for OMAP3 and later chips" depends on (ARCH_OMAP3 || ARCH_OMAP4) + select USB_OHCI_CORE default y ---help--- Enables support for the on-chip OHCI controller on @@ -398,6 +420,7 @@ config USB_OHCI_ATH79 config USB_OHCI_HCD_PPC_OF_BE bool "OHCI support for OF platform bus (big endian)" depends on PPC_OF + select USB_OHCI_CORE select USB_OHCI_BIG_ENDIAN_DESC select USB_OHCI_BIG_ENDIAN_MMIO ---help--- @@ -407,6 +430,7 @@ config USB_OHCI_HCD_PPC_
35194 View diff against: View revision: Visit: trunkbranches/8.09branches/attitude_adjustmentbranches/backfirebranches/barrier_breakerbranches/chaos_calmerbranches/kamikaze-before-brngbranches/packages_8.09branches/packages_10.03.1branches/packages_10.03.2branches/packages_12.09branches/packages_14.07branches/whiterussian tags/8.09tags/8.09.1tags/8.09.2tags/8.09_rc1tags/8.09_rc2tags/attitude_adjustment_12.09tags/backfire_10.03tags/backfire_10.03.1tags/kamikaze_7.06tags/kamikaze_7.07tags/kamikaze_7.09tags/whiterussian_0.9tags/whiterussian_rc1tags/whiterussian_rc2tags/whiterussian_rc3tags/whiterussian_rc4tags/whiterussian_rc5tags/whiterussian_rc6 Last change on this file since 35194 was 35194, checked in by juhosg, 4 years ago generic: add EHCI|OHCI platform driver fix to 3.[36] Signed-off-by: Gabor Juhos File size: 1.3 KB drivers/usb/host/ohci-hcd.c a b MODULE_LICENSE ("GPL"); 11171117 11181118#ifdef CONFIG_USB_OHCI_HCD_PLATFORM 11191119#include "ohci-platform.c" 1120 #define PLATFORM_DRIVER ohci_platform_driver 1120#define OHCI_PLATFORM_DRIVER ohci_platform_driver 11211121#endif 11221122 11231123#if !defined(PCI_DRIVER) && \ … … MODULE_LICENSE ("GPL"); 11281128 !defined(SA1111_DRIVER) && \ 11291129 !defined(PS3_SYSTEM_BUS_DRIVER) && \ 11301130 !defined(SM501_OHCI_DRIVER) && \ 1131 !defined(TMIO_OHCI_DRIVER) 1131 !defined(TMIO_OHCI_DRIVER) && \ 1132 !defined(OHCI_PLATFORM_DRIVER) 11321133#error "missing bus glue for ohci-hcd" 11331134#endif 11341135 … … static int __init ohci_hcd_mod_init(void 12061207 goto error_tmio; 12071208#endif 12081209 1210#ifdef OHCI_PLATFORM_DRIVER 1211 retval = platform_driver_register(&OHCI_PLATFORM_DRIVER); 1212 if (retval < 0) 1213 goto error_ohci; 1214#endif 1215 12091216 return retval; 12101217 12111218 /* Error path */ 1219#ifdef OHCI_PLATFORM_DRIVER 1220 platform_driver_unregister(&OHCI_PLATFORM_DRIVER); 1221error_ohci: 1222#endif 12121223#ifdef TMIO_OHCI_DRIVER 12131224 platform_driver_unregister(&TMIO_OHCI_DRIVER); 1